Open
Conversation
mutebg
reviewed
May 18, 2023
Comment on lines
+130
to
+132
| type FontPaths = { | ||
| [key: string]: string; | ||
| }; |
Contributor
There was a problem hiding this comment.
Everything looks good, in an ideal world we can export this directly from the publisher and createFontFacesForTheme to be part of the newskit-theme/title so that we can add the necessary types.
like type
type FontPaths = {
'Poppins': string,
'DM Mono': string,
};
that way we can guarantee the people provide all fonts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #000
What
I have done:
I have tested manually:
Before:
After:
Who should review this PR:
How to test: